utils/pub/git_source.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/git_source.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment in https://codereview.chromium.org/11365196/diff/6001/pkg/intl/lib/date_format.dart Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/git_source.dart

diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart

index e00e4e06698c32fe0df42c87b992ec1f130ed6a4..c1a374ed6916f3812c70f2b90b5a57172a541d42 100644

--- a/utils/pub/git_source.dart

+++ b/utils/pub/git_source.dart

@@ -152,7 +152,7 @@ class GitSource extends Source {

// have the right working directory when pub spawns git, so the relative

// path fails. To work around it, if [from] looks like a relative path then

// manually make it absolute here. Should figure out what's really going on.

- const URL_LIKE = const RegExp(r'^[a-z]+\:');

+ final URL_LIKE = new RegExp(r'^[a-z]+\:');

Bob Nystrom 2012/11/12 18:55:05 "final" -> "var". We don't bother to use "final" f

Anders Johnsen 2012/11/13 06:42:32 Done.

if (!URL_LIKE.hasMatch(from)) {

from = getFullPath(from);

}