samples/markdown/html_renderer.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/markdown/html_renderer.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment in https://codereview.chromium.org/11365196/diff/6001/pkg/intl/lib/date_format.dart Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/markdown/html_renderer.dart

diff --git a/samples/markdown/html_renderer.dart b/samples/markdown/html_renderer.dart

index 943613d9727c3487d0dd82aba7535d8a96a0119a..148b5bf2ee99f664a6af7b55093e2ea08bba6743 100644

--- a/samples/markdown/html_renderer.dart

+++ b/samples/markdown/html_renderer.dart

@@ -6,7 +6,7 @@ String renderToHtml(List<Node> nodes) => new HtmlRenderer().render(nodes);

/// Translates a parsed AST to HTML.

class HtmlRenderer implements NodeVisitor {

- static const _BLOCK_TAGS = const RegExp(

+ static const _BLOCK_TAGS = new RegExp(

Bob Nystrom 2012/11/12 18:55:05 "const" -> "final"

Anders Johnsen 2012/11/13 06:42:32 Done.

'blockquote|h1|h2|h3|h4|h5|h6|hr|p|pre');

StringBuffer buffer;