Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1140633003: Reapply "Resolve references to "this" the same way as normal variables"" (Closed)

Created:
5 years, 7 months ago by wingo
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev, Yang, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reapply "Resolve references to "this" the same way as normal variables"" This reapplies https://codereview.chromium.org/1136073002, along with the followups: Remove Scope::scope_uses_this_ flag https://codereview.chromium.org/1128963005 and PPC: Resolve references to "this" the same way as normal variables https://codereview.chromium.org/1134073003 R=rossberg@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1136883006 Cr-Commit-Position: refs/heads/master@{#28458} Committed: https://crrev.com/66665ae7274224ace841560462baee95ae3cc6cc Cr-Commit-Position: refs/heads/master@{#28484}

Patch Set 1 #

Patch Set 2 : ScopeInfo records slot of "this" binding; formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+503 lines, -196 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +45 lines, -14 lines 0 comments Download
M src/contexts.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/objects.h View 1 4 chunks +33 lines, -14 lines 0 comments Download
M src/parser.cc View 1 7 chunks +18 lines, -12 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/preparser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 3 chunks +60 lines, -8 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +17 lines, -3 lines 0 comments Download
M src/scopeinfo.cc View 1 8 chunks +63 lines, -4 lines 0 comments Download
M src/scopes.h View 7 chunks +20 lines, -13 lines 0 comments Download
M src/scopes.cc View 1 12 chunks +52 lines, -41 lines 0 comments Download
M src/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-scopes.js View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/arrow-functions-this.js View 1 chunk +81 lines, -0 lines 0 comments Download
M test/mjsunit/testcfg.py View 2 chunks +2 lines, -1 line 0 comments Download
A + test/mjsunit/this-dynamic-lookup.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
wingo
Round and round we go! Patchset 1 is patch as reverted; PS2 adds a slot ...
5 years, 7 months ago (2015-05-19 12:51:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140633003/20001
5 years, 7 months ago (2015-05-19 12:54:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 13:19:17 UTC) #5
rossberg
lgtm
5 years, 7 months ago (2015-05-19 14:28:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140633003/20001
5 years, 7 months ago (2015-05-19 14:48:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 14:51:16 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 14:51:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66665ae7274224ace841560462baee95ae3cc6cc
Cr-Commit-Position: refs/heads/master@{#28484}

Powered by Google App Engine
This is Rietveld 408576698