src/compiler.cc - Issue 1140633003: Reapply "Resolve references to "this" the same way as normal variables""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1140633003: Reapply "Resolve references to "this" the same way as normal variables"" (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: ScopeInfo records slot of "this" binding; formatting Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index a0e93d79619a332f0eb285aeaa4872f7bcd993ad..1517cdb1ec1bc72e9e2c4839cfdb10b30ad07767 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -223,8 +223,7 @@ bool CompilationInfo::is_simple_parameter_list() {

bool CompilationInfo::MayUseThis() const {

- return scope()->uses_this() || scope()->inner_uses_this() ||

- scope()->calls_sloppy_eval();

+ return scope()->has_this_declaration() && scope()->receiver()->is_used();

}

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »