Issue 1128963005: Remove Scope::scope_uses_this_ flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128963005: Remove Scope::scope_uses_this_ flag (Closed)

Created:
5 years, 7 months ago by wingo

Modified:
5 years, 7 months ago

Reviewers:
arv (Not doing code reviews), rossberg

CC:
v8-dev, arv (Not doing code reviews)

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove Scope::scope_uses_this_ flag R=rossberg@chromium.org LOG=N BUG= Committed: https://crrev.com/aefba705869d33806d873f7b5148d090f04fdd56 Cr-Commit-Position: refs/heads/master@{#28343}

Created: 5 years, 7 months ago

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -36 lines)
M	src/compiler.cc	View	1 chunk	+1 line, -2 lines	0 comments
M	src/compiler/ast-graph-builder.cc	View	1 chunk	+1 line, -3 lines	0 comments
M	src/preparser.h	View	2 chunks	+0 lines, -2 lines	0 comments
M	src/scopes.h	View	4 chunks	+0 lines, -10 lines	0 comments
M	src/scopes.cc	View	5 chunks	+0 lines, -8 lines	0 comments
M	test/cctest/test-parsing.cc	View	5 chunks	+10 lines, -11 lines	0 comments

Total messages: 7 (2 generated)

wingo

Reapplication of https://codereview.chromium.org/1129823002 without modification.

5 years, 7 months ago (2015-05-11 15:03:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128963005/1

5 years, 7 months ago (2015-05-11 15:07:38 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-11 15:42:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/aefba705869d33806d873f7b5148d090f04fdd56
Cr-Commit-Position: refs/heads/master@{#28343}