Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1128963005: Remove Scope::scope_uses_this_ flag (Closed)

Created:
5 years, 7 months ago by wingo
Modified:
5 years, 7 months ago
CC:
v8-dev, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Scope::scope_uses_this_ flag R=rossberg@chromium.org LOG=N BUG= Committed: https://crrev.com/aefba705869d33806d873f7b5148d090f04fdd56 Cr-Commit-Position: refs/heads/master@{#28343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -36 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/preparser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/scopes.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/scopes.cc View 5 chunks +0 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wingo
Reapplication of https://codereview.chromium.org/1129823002 without modification.
5 years, 7 months ago (2015-05-11 15:03:49 UTC) #1
arv (Not doing code reviews)
Still LGTM
5 years, 7 months ago (2015-05-11 15:05:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128963005/1
5 years, 7 months ago (2015-05-11 15:07:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 15:42:25 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 15:42:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aefba705869d33806d873f7b5148d090f04fdd56
Cr-Commit-Position: refs/heads/master@{#28343}

Powered by Google App Engine
This is Rietveld 408576698