Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1134073003: PPC: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Resolve references to "this" the same way as normal variables Port bd56d279b612f92d2d1d25f92d32fe7f42a455ca Original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>;. This is a reapplication of https://codereview.chromium.org/1130733003. R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/1ac6e30dd0d9c23d4926860f04a0067ba0d416a9 Cr-Commit-Position: refs/heads/master@{#28342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/ppc/full-codegen-ppc.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-11 14:00:24 UTC) #1
wingo
lgtm, ${deity} willing this is the last time we will have to poke this patch.
5 years, 7 months ago (2015-05-11 14:02:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134073003/1
5 years, 7 months ago (2015-05-11 14:09:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 14:34:37 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 14:34:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ac6e30dd0d9c23d4926860f04a0067ba0d416a9
Cr-Commit-Position: refs/heads/master@{#28342}

Powered by Google App Engine
This is Rietveld 408576698