Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139723004: Preliminary attempt to remove batch tracker (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup5
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : more cleanup #

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -808 lines) Patch
M gm/beziereffects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 10 chunks +32 lines, -49 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 2 3 chunks +4 lines, -17 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 7 chunks +5 lines, -24 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 5 chunks +15 lines, -25 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 6 chunks +10 lines, -20 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 6 chunks +10 lines, -23 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 3 13 chunks +62 lines, -61 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 2 3 chunks +3 lines, -10 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 2 2 chunks +3 lines, -29 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 28 chunks +79 lines, -142 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 2 1 chunk +13 lines, -6 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 3 chunks +12 lines, -16 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 10 chunks +19 lines, -14 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 23 chunks +46 lines, -84 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 3 chunks +9 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 8 chunks +20 lines, -30 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 25 chunks +65 lines, -71 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 12 chunks +27 lines, -17 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 24 chunks +51 lines, -80 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 2 1 chunk +1 line, -10 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 2 1 chunk +11 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-18 18:02:25 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-05-19 12:19:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139723004/40001
5 years, 7 months ago (2015-05-19 13:43:19 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/cbfe91d82500f4ae8c3ff7bd74b3021a4b89fd84
5 years, 7 months ago (2015-05-19 13:49:38 UTC) #6
joshualitt
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1132323003/ by joshualitt@google.com. ...
5 years, 7 months ago (2015-05-19 14:14:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139723004/60001
5 years, 7 months ago (2015-05-19 15:17:28 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 15:23:35 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b8c241ad099f3f0c2cbf3e7c10f5f6207175d490

Powered by Google App Engine
This is Rietveld 408576698