Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137513003: Apply bleed-avoidance insets _after_ constraining the border (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
chrishtr, f(malita)
CC:
blink-reviews, krit, pdr+graphicswatchlist_chromium.org, blink-reviews-style_chromium.org, dshwang, jbroman, slimming-paint-reviews_chromium.org, danakj, Rik, Justin Novosad, blink-reviews-paint_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply bleed-avoidance insets _after_ constraining the border When shrinking the background to avoid bleeding artifacts, apply the inset after computing and constraining the (outer) border. If the shrinking inset is applied before constraining, the shape of the border will differ in some (extreme) cases. It's also more consistent with how 'double' style borders are handled. This allows dropping the optional FloatRectOutsets argument from ComputedStyle::getRoundedBorderFor() and BoxPainter::getBackgroundRoundedRect(). BUG=473119, 445598 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195263

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop FloatRoundedRect::shrink. #

Patch Set 3 : Bah. #

Patch Set 4 : Sign sigh. #

Patch Set 5 : Rebase; TEs. #

Patch Set 6 : One more TE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/paint/BoxPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
M Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/ComputedStyle.cpp View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
Example where this gives a noticable difference: <!doctype html> <style> p { width: 100px; height: ...
5 years, 7 months ago (2015-05-11 17:11:02 UTC) #2
f(malita)
On 2015/05/11 17:11:02, fs wrote: > Example where this gives a noticable difference: > > ...
5 years, 7 months ago (2015-05-11 18:09:14 UTC) #3
fs
https://codereview.chromium.org/1137513003/diff/1/Source/platform/geometry/FloatRoundedRect.cpp File Source/platform/geometry/FloatRoundedRect.cpp (right): https://codereview.chromium.org/1137513003/diff/1/Source/platform/geometry/FloatRoundedRect.cpp#newcode221 Source/platform/geometry/FloatRoundedRect.cpp:221: m_radii.shrink(-insets.top(), -insets.bottom(), -insets.left(), -insets.right()); On 2015/05/11 18:09:14, f(malita) wrote: ...
5 years, 7 months ago (2015-05-12 08:53:55 UTC) #4
fs
On 2015/05/11 18:09:14, f(malita) wrote: > On 2015/05/11 17:11:02, fs wrote: > > Example where ...
5 years, 7 months ago (2015-05-12 13:13:26 UTC) #5
f(malita)
On 2015/05/12 13:13:26, fs wrote: > Here's the result of that (shouldn't have used a ...
5 years, 7 months ago (2015-05-12 13:43:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137513003/90001
5 years, 7 months ago (2015-05-12 16:46:12 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:59:13 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195263

Powered by Google App Engine
This is Rietveld 408576698