Apply bleed-avoidance insets _after_ constraining the border

Source/platform/geometry/FloatRoundedRect.cpp

 /*
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 197 matching lines @@
     // Considering the inflation factor of shorter size to scale the radii seems appropriate here
     float factor;
     if (m_rect.width() < m_rect.height())
         factor = old.width() ? (float)m_rect.width() / old.width() : int(0);
     else
         factor = old.height() ? (float)m_rect.height() / old.height() : int(0);
 
     m_radii.scale(factor);
 }
 
+void FloatRoundedRect::shrink(const FloatRectOutsets& insets)
+{
+    m_rect.expand(insets);
+    m_radii.shrink(-insets.top(), -insets.bottom(), -insets.left(), -insets.right());

[f(malita), 2015/05/11 18:09:14]

Nit: I find the difference in Radii::shrink() vs. Radii::expand() semantics
super annoying. It's not immediately obvious what's going on here (rect expand
vs. radii shrink vs. sign(insets)), so maybe we should avoid adding this
FloatRoundedRect API. Can we adjust the rect/radii explicitly in
backgroundRoundedRectAdjustedForBleedAvoidance() and just use a new
FloatRoundedRect instead?

[fs, 2015/05/12 08:53:55]

Annoying indeed...
I'd semi-planed a follow-up which used it in yet another place - mutating a
FloatRoundedRect is kind of tedious...

I was hoping we could eventually get a structure like:

<compute (outer) border>
<determine inset>
<apply inset (if needed)>

I'm a bit stumped by the BackgroundOverBorder case though (since it doesn't
factor in continuation effects.)

+}
+
 bool FloatRoundedRect::intersectsQuad(const FloatQuad& quad) const
 {
     if (!quad.intersectsRect(m_rect))
         return false;
 
     const FloatSize& topLeft = m_radii.topLeft();
     if (!topLeft.isEmpty()) {
         FloatRect rect(m_rect.x(), m_rect.y(), topLeft.width(), topLeft.height());
         if (quad.intersectsRect(rect)) {
             FloatPoint center(m_rect.x() + topLeft.width(), m_rect.y() + topLeft.height());
@@ skipping 124 matching lines @@
 void FloatRoundedRect::show()
 {
     fprintf(stderr, "FloatRoundedRect:\n rect: ");
     m_rect.show();
     fprintf(stderr, " radii: ");
     m_radii.show();
 }
 #endif
 
 } // namespace blink