Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Side by Side Diff: Source/core/style/ComputedStyle.cpp

Issue 1137513003: Apply bleed-avoidance insets _after_ constraining the border (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: One more TE. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 992 matching lines...) Expand 10 before | Expand all | Expand 10 after
1003 Color ComputedStyle::visitedLinkColor() const { return inherited->visitedLinkCol or; } 1003 Color ComputedStyle::visitedLinkColor() const { return inherited->visitedLinkCol or; }
1004 void ComputedStyle::setColor(const Color& v) { SET_VAR(inherited, color, v); } 1004 void ComputedStyle::setColor(const Color& v) { SET_VAR(inherited, color, v); }
1005 void ComputedStyle::setVisitedLinkColor(const Color& v) { SET_VAR(inherited, vis itedLinkColor, v); } 1005 void ComputedStyle::setVisitedLinkColor(const Color& v) { SET_VAR(inherited, vis itedLinkColor, v); }
1006 1006
1007 short ComputedStyle::horizontalBorderSpacing() const { return inherited->horizon tal_border_spacing; } 1007 short ComputedStyle::horizontalBorderSpacing() const { return inherited->horizon tal_border_spacing; }
1008 short ComputedStyle::verticalBorderSpacing() const { return inherited->vertical_ border_spacing; } 1008 short ComputedStyle::verticalBorderSpacing() const { return inherited->vertical_ border_spacing; }
1009 void ComputedStyle::setHorizontalBorderSpacing(short v) { SET_VAR(inherited, hor izontal_border_spacing, v); } 1009 void ComputedStyle::setHorizontalBorderSpacing(short v) { SET_VAR(inherited, hor izontal_border_spacing, v); }
1010 void ComputedStyle::setVerticalBorderSpacing(short v) { SET_VAR(inherited, verti cal_border_spacing, v); } 1010 void ComputedStyle::setVerticalBorderSpacing(short v) { SET_VAR(inherited, verti cal_border_spacing, v); }
1011 1011
1012 FloatRoundedRect ComputedStyle::getRoundedBorderFor(const LayoutRect& borderRect , 1012 FloatRoundedRect ComputedStyle::getRoundedBorderFor(const LayoutRect& borderRect ,
1013 bool includeLogicalLeftEdge, bool includeLogicalRightEdge, const FloatRectOu tsets* insets) const 1013 bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const
1014 { 1014 {
1015 FloatRect rect(pixelSnappedIntRect(borderRect)); 1015 FloatRoundedRect roundedRect(pixelSnappedIntRect(borderRect));
1016 if (insets)
1017 rect.expand(*insets);
1018
1019 FloatRoundedRect roundedRect(rect);
1020 if (hasBorderRadius()) { 1016 if (hasBorderRadius()) {
1021 FloatRoundedRect::Radii radii = calcRadiiFor(surround->border, borderRec t.size()); 1017 FloatRoundedRect::Radii radii = calcRadiiFor(surround->border, borderRec t.size());
1022 if (insets)
1023 radii.shrink(-insets->top(), -insets->bottom(), -insets->left(), -in sets->right());
1024
1025 roundedRect.includeLogicalEdges(radii, isHorizontalWritingMode(), includ eLogicalLeftEdge, includeLogicalRightEdge); 1018 roundedRect.includeLogicalEdges(radii, isHorizontalWritingMode(), includ eLogicalLeftEdge, includeLogicalRightEdge);
1026 roundedRect.constrainRadii(); 1019 roundedRect.constrainRadii();
1027 } 1020 }
1028 return roundedRect; 1021 return roundedRect;
1029 } 1022 }
1030 1023
1031 FloatRoundedRect ComputedStyle::getRoundedInnerBorderFor(const LayoutRect& borde rRect, bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const 1024 FloatRoundedRect ComputedStyle::getRoundedInnerBorderFor(const LayoutRect& borde rRect, bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const
1032 { 1025 {
1033 bool horizontal = isHorizontalWritingMode(); 1026 bool horizontal = isHorizontalWritingMode();
1034 1027
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 horizontal || includeLogicalRightEdge); 1729 horizontal || includeLogicalRightEdge);
1737 1730
1738 edges[BSLeft] = BorderEdge(borderLeftWidth(), 1731 edges[BSLeft] = BorderEdge(borderLeftWidth(),
1739 visitedDependentColor(CSSPropertyBorderLeftColor), 1732 visitedDependentColor(CSSPropertyBorderLeftColor),
1740 borderLeftStyle(), 1733 borderLeftStyle(),
1741 borderLeftIsTransparent(), 1734 borderLeftIsTransparent(),
1742 !horizontal || includeLogicalLeftEdge); 1735 !horizontal || includeLogicalLeftEdge);
1743 } 1736 }
1744 1737
1745 } // namespace blink 1738 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698