Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 11369018: cc: Switch from WebCore::FloatPoint3D to gfx::Point3F and gfx::Vector3dF in the compositor (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, shawnsingh, backer, piman
Visibility:
Public.

Description

cc: Switch from WebCore::FloatPoint3D to gfx::Point3F and gfx::Vector3dF in the compositor This entirely removes our usage of FloatPoint3D, and removes the stub header as well. Covered by existing tests; just changing data types. This depends on https://codereview.chromium.org/11367025/ BUG=147395 R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165484

Patch Set 1 #

Patch Set 2 : Missed a stub header #

Patch Set 3 : Missing base files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -99 lines) Patch
M cc/cc.gyp View 1 2 chunks +0 lines, -2 lines 1 comment Download
M cc/layer_quad.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layer_sorter.h View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/layer_sorter.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M cc/math_util.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/math_util.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M cc/math_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
D cc/stubs/FloatPoint3D.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
cc/stubs/float_point_3d.h View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
8 years, 1 month ago (2012-11-01 02:03:48 UTC) #1
enne (OOO)
lgtm https://codereview.chromium.org/11369018/diff/5001/cc/cc.gyp File cc/cc.gyp (left): https://codereview.chromium.org/11369018/diff/5001/cc/cc.gyp#oldcode259 cc/cc.gyp:259: 'stubs/FloatPoint3D.h', \o/
8 years, 1 month ago (2012-11-01 02:45:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11369018/5001
8 years, 1 month ago (2012-11-01 18:50:05 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-01 18:55:28 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 18:56:42 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698