Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1134593006: [Telemetry] Kill page_test.RunPage. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Kill page_test.RunPage. This helps making sure that page.Page are the sole owner of defining the interactions with the page. BUG=455391, 470147 Committed: https://crrev.com/a085d53d348778b486ff3a937dc24f9d43d775c4 Cr-Commit-Position: refs/heads/master@{#330474}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 2 chunks +6 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/record_wpr.py View 1 2 chunks +2 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/record_wpr_unittest.py View 1 2 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
nednguyen
5 years, 7 months ago (2015-05-18 21:03:02 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-18 21:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134593006/1
5 years, 7 months ago (2015-05-18 21:12:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/77272) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-18 21:20:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134593006/20001
5 years, 7 months ago (2015-05-18 21:45:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/58743)
5 years, 7 months ago (2015-05-18 23:37:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134593006/40001
5 years, 7 months ago (2015-05-19 00:34:15 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-19 03:46:17 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 03:48:00 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a085d53d348778b486ff3a937dc24f9d43d775c4
Cr-Commit-Position: refs/heads/master@{#330474}

Powered by Google App Engine
This is Rietveld 408576698