Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 1134593006: [Telemetry] Kill page_test.RunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/record_wpr.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/shared_page_state.py
diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py
index f32ac08a0082ea87906c7817ff7b89b6139896a6..41a06966a22173179a0776f46324f89274519bf9 100644
--- a/tools/telemetry/telemetry/page/shared_page_state.py
+++ b/tools/telemetry/telemetry/page/shared_page_state.py
@@ -14,6 +14,7 @@ from telemetry.core import util
from telemetry.core import wpr_modes
from telemetry import decorators
from telemetry.page import page_test
+from telemetry.page import action_runner as action_runner_module
from telemetry.story import shared_state
from telemetry.util import exception_formatter
from telemetry.util import file_handle
@@ -258,7 +259,11 @@ class SharedPageState(shared_state.SharedState):
try:
self._PreparePage()
self._ImplicitPageNavigation()
- self._test.RunPage(self._current_page, self._current_tab, results)
+ action_runner = action_runner_module.ActionRunner(
+ self._current_tab, skip_waits=self._current_page.skip_waits)
+ self._current_page.RunPageInteractions(action_runner)
+ self._test.ValidateAndMeasurePage(
+ self._current_page, self._current_tab, results)
except exceptions.Error:
if self._test.is_multi_tab_test:
# Avoid trying to recover from an unknown multi-tab state.
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/record_wpr.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698