Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: tools/telemetry/telemetry/record_wpr_unittest.py

Issue 1134593006: [Telemetry] Kill page_test.RunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/record_wpr.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/record_wpr_unittest.py
diff --git a/tools/telemetry/telemetry/record_wpr_unittest.py b/tools/telemetry/telemetry/record_wpr_unittest.py
index c0ba943b95d04db93094e4333a703eba1c0b209a..d78bba03671b7c56b13a1b51080e8848746f5773 100644
--- a/tools/telemetry/telemetry/record_wpr_unittest.py
+++ b/tools/telemetry/telemetry/record_wpr_unittest.py
@@ -100,24 +100,19 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):
record_page_test.RunNavigateSteps(page, self._tab)
self.assertTrue('RunNavigateSteps' in page.func_calls)
- record_page_test.RunPage(page, self._tab, results=None)
- self.assertTrue('RunPageInteractions' in page.func_calls)
-
# When the RecorderPageTest is created from a Benchmark, the benchmark will
# have a PageTest, specified by its test attribute.
def testRunPage_OnlyRunBenchmarkAction(self):
record_page_test = record_wpr.RecorderPageTest()
record_page_test.page_test = MockBenchmark().test()
page = MockPage(page_set=MockPageSet(url=self._url), url=self._url)
- record_page_test.RunPage(page, self._tab, results=None)
- self.assertTrue('RunPageInteractions' in page.func_calls)
- self.assertFalse('RunSmoothness' in page.func_calls)
+ record_page_test.ValidateAndMeasurePage(page, self._tab, results=None)
def testRunPage_CallBenchmarksPageTestsFunctions(self):
record_page_test = record_wpr.RecorderPageTest()
record_page_test.page_test = MockBenchmark().test()
page = MockPage(page_set=MockPageSet(url=self._url), url=self._url)
- record_page_test.RunPage(page, self._tab, results=None)
+ record_page_test.ValidateAndMeasurePage(page, self._tab, results=None)
self.assertEqual(1, len(record_page_test.page_test.func_calls))
self.assertEqual('ValidateAndMeasurePage',
record_page_test.page_test.func_calls[0])
« no previous file with comments | « tools/telemetry/telemetry/record_wpr.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698