Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: tools/telemetry/telemetry/record_wpr.py

Issue 1134593006: [Telemetry] Kill page_test.RunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/record_wpr.py
diff --git a/tools/telemetry/telemetry/record_wpr.py b/tools/telemetry/telemetry/record_wpr.py
index 8ce19746f37e05e8a86ebd6576768d163205de6b..0899a3d7a8c2620fac5a7e8246c3dbc9ccc479fc 100644
--- a/tools/telemetry/telemetry/record_wpr.py
+++ b/tools/telemetry/telemetry/record_wpr.py
@@ -44,6 +44,8 @@ class RecorderPageTest(page_test.PageTest):
def DidNavigateToPage(self, page, tab):
if self.page_test:
self.page_test.DidNavigateToPage(page, tab)
+ tab.WaitForDocumentReadyStateToBeComplete()
+ util.WaitFor(tab.HasReachedQuiescence, 30)
def CleanUpAfterPage(self, page, tab):
if self.page_test:
@@ -53,16 +55,6 @@ class RecorderPageTest(page_test.PageTest):
if self.page_test:
self.page_test.ValidateAndMeasurePage(page, tab, results)
- def RunPage(self, page, tab, results):
- tab.WaitForDocumentReadyStateToBeComplete()
- util.WaitFor(tab.HasReachedQuiescence, 30)
-
- if self.page_test:
- self.page_test.RunPage(page, tab, results)
- return
-
- super(RecorderPageTest, self).RunPage(page, tab, results)
-
def RunNavigateSteps(self, page, tab):
if self.page_test:
self.page_test.RunNavigateSteps(page, tab)
« no previous file with comments | « tools/telemetry/telemetry/page/shared_page_state.py ('k') | tools/telemetry/telemetry/record_wpr_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698