Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1133363002: Getting rid of duplicate includes from media/ (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
xhwang, DaleCurtis
CC:
chromium-reviews, miu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Getting rid of duplicate includes from media/ As any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes). This removes all includes from $X.cc files where the $X.h has the same include to confirm to the style guide. BUG=460988 Committed: https://crrev.com/19bf2cea5af3e4e4c499a41a90a6603d911616e5 Cr-Commit-Position: refs/heads/master@{#329923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -168 lines) Patch
M media/audio/alsa/alsa_input.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/alsa/alsa_output.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/alsa/alsa_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/alsa/alsa_wrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_input_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_input_device.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_device.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_resampler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/clockless_audio_sink.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/media_source_player.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/audio_decoder_config.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/audio_discard_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/container_names.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/data_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/decoder_buffer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/key_systems.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/base/key_systems_support_uma.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/text_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/video_frame.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/cdm_session_adapter.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/blink/encrypted_media_player_support.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/test_response_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/cast/logging/log_deserializer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/logging/simple_event_subscriber.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/net/cast_transport_sender_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/net/rtcp/rtcp_builder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/net/rtp/rtp_sender.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/net/udp_transport.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/receiver/audio_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/sender/audio_encoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/test/fake_media_source.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/key_system_names.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/ppapi/cdm_file_io_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/ppapi/cdm_helpers.cc View 1 chunk +1 line, -11 lines 0 comments Download
M media/cdm/ppapi/cdm_logging.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/audio_file_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/decoder_stream.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/stream_parser_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/formats/common/offset_byte_queue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/es_adapter_video.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/es_parser_adts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/es_parser_h264.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/formats/mp2t/es_parser_mpeg1audio.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/formats/mp4/aac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp4/avc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp4/box_reader.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/midi/midi_manager_alsa.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/midi/midi_manager_usb.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/midi/midi_manager_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M media/midi/usb_midi_device_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/midi/usb_midi_input_stream.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/video_renderer_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/video/capture/android/video_capture_device_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/android/video_capture_device_factory_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/file_video_capture_device.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
anujsharma
Hi Xhwang, As per the C++ style guide, if a .h includes something, the .cc ...
5 years, 7 months ago (2015-05-13 07:16:46 UTC) #2
xhwang
+dalecurtis Is this CL generated by the script attached in the bug? I can see ...
5 years, 7 months ago (2015-05-14 05:02:37 UTC) #4
anujsharma
On 2015/05/14 05:02:37, xhwang wrote: > +dalecurtis > > Is this CL generated by the ...
5 years, 7 months ago (2015-05-14 07:52:00 UTC) #5
DaleCurtis
I think if we're applying this to all of Chromium, it's fine to do in ...
5 years, 7 months ago (2015-05-14 16:24:47 UTC) #6
anujsharma
On 2015/05/14 16:24:47, DaleCurtis wrote: > I think if we're applying this to all of ...
5 years, 7 months ago (2015-05-14 19:30:58 UTC) #7
anujsharma
@xhwang Dalecurtis looks ok with the change. Could you please also give thumbs up to ...
5 years, 7 months ago (2015-05-14 19:32:24 UTC) #8
xhwang
Sure. LGTM!
5 years, 7 months ago (2015-05-14 19:36:24 UTC) #9
anujsharma
On 2015/05/14 19:36:24, xhwang wrote: > Sure. LGTM! Thanks xhwang for lgtm :)
5 years, 7 months ago (2015-05-14 19:45:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133363002/1
5 years, 7 months ago (2015-05-14 19:48:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 20:41:17 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 20:42:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19bf2cea5af3e4e4c499a41a90a6603d911616e5
Cr-Commit-Position: refs/heads/master@{#329923}

Powered by Google App Engine
This is Rietveld 408576698