Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed)

Created:
5 years, 7 months ago by Srirama
Modified:
5 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri (slow - plz ping), nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate MediaPlayer & MediaPlayerClient abstractions This is a chromium side patch to help eliminate MediaPlayer and MediaPlayerClient interfaces. This helps HTMLMediaElement to directly interact with WebMediaPlayer. BUG=350571, 310466 Blink CL: https://codereview.chromium.org/1055503002/ Committed: https://crrev.com/26f864d0a0671225b734141d63a31a36880b9976 Cr-Commit-Position: refs/heads/master@{#338641}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : added new path for createMediaPlayer #

Total comments: 10

Patch Set 3 : Fixed review comments #

Patch Set 4 : Rebase and code cleanup #

Patch Set 5 : fixed compile error in webmediaplayer_impl #

Total comments: 3

Patch Set 6 : Add new path for createMediaPlayer() #

Total comments: 24

Patch Set 7 : Fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -53 lines) Patch
M components/html_viewer/frame.h View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M components/html_viewer/frame.cc View 1 2 3 4 5 6 2 chunks +12 lines, -1 line 0 comments Download
M components/html_viewer/html_document.h View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 2 3 4 5 6 2 chunks +12 lines, -1 line 0 comments Download
M components/html_viewer/media_factory.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M components/html_viewer/media_factory.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 6 7 chunks +12 lines, -11 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 9 chunks +26 lines, -12 lines 0 comments Download
M media/blink/encrypted_media_player_support.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/encrypted_media_player_support.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 2 3 4 5 6 3 chunks +11 lines, -7 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 5 6 5 chunks +10 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_util.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 34 (7 generated)
Srirama
PTAL.
5 years, 7 months ago (2015-05-19 10:42:25 UTC) #3
ddorwin
https://codereview.chromium.org/1133033003/diff/20001/content/renderer/render_frame_impl.h File content/renderer/render_frame_impl.h (right): https://codereview.chromium.org/1133033003/diff/20001/content/renderer/render_frame_impl.h#newcode357 content/renderer/render_frame_impl.h:357: virtual blink::WebMediaPlayer* createMediaPlayer( Because Blink is independent of Chromium, ...
5 years, 7 months ago (2015-05-19 17:09:20 UTC) #5
Srirama
https://codereview.chromium.org/1133033003/diff/20001/content/renderer/render_frame_impl.h File content/renderer/render_frame_impl.h (right): https://codereview.chromium.org/1133033003/diff/20001/content/renderer/render_frame_impl.h#newcode357 content/renderer/render_frame_impl.h:357: virtual blink::WebMediaPlayer* createMediaPlayer( On 2015/05/19 17:09:20, ddorwin wrote: > ...
5 years, 7 months ago (2015-05-19 18:20:35 UTC) #6
ddorwin
On 2015/05/19 18:20:35, Srirama wrote: > https://codereview.chromium.org/1133033003/diff/20001/content/renderer/render_frame_impl.h > File content/renderer/render_frame_impl.h (right): > > https://codereview.chromium.org/1133033003/diff/20001/content/renderer/render_frame_impl.h#newcode357 > ...
5 years, 7 months ago (2015-05-19 22:53:41 UTC) #7
Srirama
I have modified the existing unused createMediaPlayer method in render_frame_impl and added a new path ...
5 years, 7 months ago (2015-05-26 14:30:02 UTC) #8
ddorwin
I don't understand this approach (along with concerns in the Blink CL). https://codereview.chromium.org/1133033003/diff/40001/components/html_viewer/html_document.cc File components/html_viewer/html_document.cc ...
5 years, 7 months ago (2015-05-26 21:43:07 UTC) #9
Srirama
This is what i am trying to do, i may be doing a bit more ...
5 years, 7 months ago (2015-05-27 14:48:50 UTC) #10
Srirama
I have explained one more approach in my Blink CL, probably that may address your ...
5 years, 7 months ago (2015-05-27 17:20:12 UTC) #11
Srirama
PTAL. Done all the changes required without worrying about two approaches. Once i get approval ...
5 years, 6 months ago (2015-06-09 14:26:24 UTC) #13
Srirama
Gentle reminder
5 years, 6 months ago (2015-06-23 12:38:21 UTC) #15
philipj_slow
Looks like this is entirely a question of getting the EME bits right, but let ...
5 years, 5 months ago (2015-07-01 13:52:02 UTC) #16
Srirama
On 2015/07/01 13:52:02, philipj wrote: > Looks like this is entirely a question of getting ...
5 years, 5 months ago (2015-07-01 14:06:02 UTC) #17
ddorwin
LG2M once the Blink interface change dance is handled. See https://codereview.chromium.org/1055503002/. https://codereview.chromium.org/1133033003/diff/140001/media/blink/webmediaplayer_impl.h File media/blink/webmediaplayer_impl.h (right): ...
5 years, 5 months ago (2015-07-06 20:44:30 UTC) #18
Srirama
https://codereview.chromium.org/1133033003/diff/140001/media/blink/webmediaplayer_impl.h File media/blink/webmediaplayer_impl.h (right): https://codereview.chromium.org/1133033003/diff/140001/media/blink/webmediaplayer_impl.h#newcode33 media/blink/webmediaplayer_impl.h:33: #include "third_party/WebKit/public/platform/WebMediaPlayerEncryptedMediaClient.h" On 2015/07/06 20:44:29, ddorwin wrote: > Can ...
5 years, 5 months ago (2015-07-08 17:43:42 UTC) #19
Srirama
PTAL. I have added path for new createMediaPlayer() method. This should land after https://codereview.chromium.org/1125353004/ https://codereview.chromium.org/1133033003/diff/140001/media/blink/webmediaplayer_impl.h ...
5 years, 5 months ago (2015-07-10 15:29:30 UTC) #20
ddorwin
https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h File components/html_viewer/frame.h (right): https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h#newcode136 components/html_viewer/frame.h:136: virtual blink::WebMediaPlayer* createMediaPlayer( On 2015/07/10 15:29:30, Srirama wrote: > ...
5 years, 5 months ago (2015-07-10 17:56:57 UTC) #21
Srirama
https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h File components/html_viewer/frame.h (right): https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h#newcode136 components/html_viewer/frame.h:136: virtual blink::WebMediaPlayer* createMediaPlayer( On 2015/07/10 17:56:56, ddorwin wrote: > ...
5 years, 5 months ago (2015-07-10 18:36:03 UTC) #22
ddorwin
https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h File components/html_viewer/frame.h (right): https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h#newcode136 components/html_viewer/frame.h:136: virtual blink::WebMediaPlayer* createMediaPlayer( On 2015/07/10 18:36:02, Srirama wrote: > ...
5 years, 5 months ago (2015-07-10 18:47:43 UTC) #23
Srirama
Addressed all the review comments. PTAL. https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h File components/html_viewer/frame.h (right): https://codereview.chromium.org/1133033003/diff/160001/components/html_viewer/frame.h#newcode136 components/html_viewer/frame.h:136: virtual blink::WebMediaPlayer* createMediaPlayer( ...
5 years, 5 months ago (2015-07-11 08:44:10 UTC) #24
ddorwin
LGTM. You'll need OWNERS review for components/html_viewer/ and content/renderer/. https://codereview.chromium.org/1133033003/diff/160001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/1133033003/diff/160001/content/renderer/render_frame_impl.cc#newcode119 content/renderer/render_frame_impl.cc:119: ...
5 years, 5 months ago (2015-07-13 17:58:19 UTC) #25
Srirama
Thanks ddorwin. sky@: Please review changes in components/. jam@: Please review changes in content/renderer/. https://codereview.chromium.org/1133033003/diff/160001/content/renderer/render_frame_impl.cc ...
5 years, 5 months ago (2015-07-13 18:33:03 UTC) #27
Srirama
On 2015/07/13 18:33:03, Srirama wrote: > Thanks ddorwin. > > sky@: Please review changes in ...
5 years, 5 months ago (2015-07-13 18:41:19 UTC) #28
jam
lgtm please add background to the bug or the cl description about the motivation for ...
5 years, 5 months ago (2015-07-13 19:00:05 UTC) #29
Srirama
On 2015/07/13 19:00:05, jam wrote: > lgtm > > please add background to the bug ...
5 years, 5 months ago (2015-07-14 04:30:33 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133033003/180001
5 years, 5 months ago (2015-07-14 04:31:35 UTC) #32
commit-bot: I haz the power
Committed patchset #7 (id:180001)
5 years, 5 months ago (2015-07-14 05:22:04 UTC) #33
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 05:23:03 UTC) #34
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/26f864d0a0671225b734141d63a31a36880b9976
Cr-Commit-Position: refs/heads/master@{#338641}

Powered by Google App Engine
This is Rietveld 408576698