components/html_viewer/frame.h - Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/frame.h

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/html_viewer/frame.h

diff --git a/components/html_viewer/frame.h b/components/html_viewer/frame.h

index 341a71891f0a442dbf31e193caacd5bd109d356c..55af3520cce0a46aecfcc7e177a094b9670db77b 100644

--- a/components/html_viewer/frame.h

+++ b/components/html_viewer/frame.h

@@ -133,11 +133,18 @@ class Frame : public blink::WebFrameClient,

virtual blink::WebStorageNamespace* createSessionStorageNamespace();

// WebFrameClient methods:

+ // TODO(srirama): Remove this method once blink updated.

virtual blink::WebMediaPlayer* createMediaPlayer(

blink::WebLocalFrame* frame,

const blink::WebURL& url,

blink::WebMediaPlayerClient* client,

blink::WebContentDecryptionModule* initial_cdm);

+ virtual blink::WebMediaPlayer* createMediaPlayer(

+ blink::WebLocalFrame* frame,

+ const blink::WebURL& url,

+ blink::WebMediaPlayerClient* client,

+ blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,

+ blink::WebContentDecryptionModule* initial_cdm);

virtual blink::WebFrame* createChildFrame(

blink::WebLocalFrame* parent,

blink::WebTreeScopeType scope,

« no previous file with comments | « no previous file | components/html_viewer/frame.cc » ('j') | no next file with comments »