Eliminate MediaPlayer & MediaPlayerClient abstractions

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 336 matching lines @@
   blink::WebPluginPlaceholder* createPluginPlaceholder(
       blink::WebLocalFrame*,
       const blink::WebPluginParams&) override;
   virtual blink::WebPlugin* createPlugin(blink::WebLocalFrame* frame,
                                          const blink::WebPluginParams& params);
   // TODO(jrummell): Remove this method once blink updated.
   virtual blink::WebMediaPlayer* createMediaPlayer(
       blink::WebLocalFrame* frame,
       const blink::WebURL& url,
       blink::WebMediaPlayerClient* client);
   virtual blink::WebMediaPlayer* createMediaPlayer(

[ddorwin, 2015/05/19 17:09:20]

Because Blink is independent of Chromium, you need to support both signatures in
Chromium before landing the Blink side. (For example, the signature above is the
old one before this new one was added. It is long overdue for deletion, but feel
free to update it for your purposes.

[Srirama, 2015/05/19 18:20:35]

I will definitely use this. Infact i need to do a lot more work before landing
this CL and blink CL. There will be multiple patches as i have noted at
https://codereview.chromium.org/1125353004/. As per Philip's suggestion i have
uploaded the changes first so that review will be easier. If you don't mind
please check the steps i have mentioned at
https://codereview.chromium.org/1125353004/#msg7 and let me know if it is fine
or suggest me if there is a better way.

       blink::WebLocalFrame* frame,
       const blink::WebURL& url,
       blink::WebMediaPlayerClient* client,
+      blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,

[ddorwin, 2015/05/19 17:09:20]

You need to update components/html_viewer/html_document.h too.

[Srirama, 2015/05/19 18:20:35]

Acknowledged.

       blink::WebContentDecryptionModule* initial_cdm);
   virtual blink::WebApplicationCacheHost* createApplicationCacheHost(
       blink::WebLocalFrame* frame,
       blink::WebApplicationCacheHostClient* client);
   virtual blink::WebWorkerContentSettingsClientProxy*
       createWorkerContentSettingsClientProxy(blink::WebLocalFrame* frame);
   virtual blink::WebExternalPopupMenu* createExternalPopupMenu(
       const blink::WebPopupMenuInfo& popup_menu_info,
       blink::WebExternalPopupMenuClient* popup_menu_client);
   virtual blink::WebCookieJar* cookieJar(blink::WebLocalFrame* frame);
@@ skipping 617 matching lines @@
 #endif
 
   base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_