Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: components/html_viewer/frame.cc

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/html_viewer/frame.h ('k') | components/html_viewer/html_document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/html_viewer/frame.h" 5 #include "components/html_viewer/frame.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 15 matching lines...) Expand all
26 #include "components/view_manager/public/cpp/view_manager.h" 26 #include "components/view_manager/public/cpp/view_manager.h"
27 #include "components/view_manager/public/interfaces/surfaces.mojom.h" 27 #include "components/view_manager/public/interfaces/surfaces.mojom.h"
28 #include "mandoline/services/navigation/public/interfaces/navigation.mojom.h" 28 #include "mandoline/services/navigation/public/interfaces/navigation.mojom.h"
29 #include "mojo/application/public/cpp/application_impl.h" 29 #include "mojo/application/public/cpp/application_impl.h"
30 #include "mojo/application/public/cpp/connect.h" 30 #include "mojo/application/public/cpp/connect.h"
31 #include "mojo/application/public/interfaces/shell.mojom.h" 31 #include "mojo/application/public/interfaces/shell.mojom.h"
32 #include "mojo/converters/geometry/geometry_type_converters.h" 32 #include "mojo/converters/geometry/geometry_type_converters.h"
33 #include "skia/ext/refptr.h" 33 #include "skia/ext/refptr.h"
34 #include "third_party/WebKit/public/platform/Platform.h" 34 #include "third_party/WebKit/public/platform/Platform.h"
35 #include "third_party/WebKit/public/platform/WebHTTPHeaderVisitor.h" 35 #include "third_party/WebKit/public/platform/WebHTTPHeaderVisitor.h"
36 #include "third_party/WebKit/public/platform/WebMediaPlayerClient.h"
36 #include "third_party/WebKit/public/platform/WebSize.h" 37 #include "third_party/WebKit/public/platform/WebSize.h"
37 #include "third_party/WebKit/public/web/WebConsoleMessage.h" 38 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
38 #include "third_party/WebKit/public/web/WebDocument.h" 39 #include "third_party/WebKit/public/web/WebDocument.h"
39 #include "third_party/WebKit/public/web/WebElement.h" 40 #include "third_party/WebKit/public/web/WebElement.h"
40 #include "third_party/WebKit/public/web/WebFrameWidget.h" 41 #include "third_party/WebKit/public/web/WebFrameWidget.h"
41 #include "third_party/WebKit/public/web/WebInputEvent.h" 42 #include "third_party/WebKit/public/web/WebInputEvent.h"
42 #include "third_party/WebKit/public/web/WebLocalFrame.h" 43 #include "third_party/WebKit/public/web/WebLocalFrame.h"
43 #include "third_party/WebKit/public/web/WebNavigationPolicy.h" 44 #include "third_party/WebKit/public/web/WebNavigationPolicy.h"
44 #include "third_party/WebKit/public/web/WebRemoteFrame.h" 45 #include "third_party/WebKit/public/web/WebRemoteFrame.h"
45 #include "third_party/WebKit/public/web/WebRemoteFrameClient.h" 46 #include "third_party/WebKit/public/web/WebRemoteFrameClient.h"
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 378
378 blink::WebStorageNamespace* Frame::createSessionStorageNamespace() { 379 blink::WebStorageNamespace* Frame::createSessionStorageNamespace() {
379 return new WebStorageNamespaceImpl(); 380 return new WebStorageNamespaceImpl();
380 } 381 }
381 382
382 blink::WebMediaPlayer* Frame::createMediaPlayer( 383 blink::WebMediaPlayer* Frame::createMediaPlayer(
383 blink::WebLocalFrame* frame, 384 blink::WebLocalFrame* frame,
384 const blink::WebURL& url, 385 const blink::WebURL& url,
385 blink::WebMediaPlayerClient* client, 386 blink::WebMediaPlayerClient* client,
386 blink::WebContentDecryptionModule* initial_cdm) { 387 blink::WebContentDecryptionModule* initial_cdm) {
388 return createMediaPlayer(frame, url, client, client, initial_cdm);
389 }
390
391 blink::WebMediaPlayer* Frame::createMediaPlayer(
392 blink::WebLocalFrame* frame,
393 const blink::WebURL& url,
394 blink::WebMediaPlayerClient* client,
395 blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,
396 blink::WebContentDecryptionModule* initial_cdm) {
387 return global_state()->media_factory()->CreateMediaPlayer( 397 return global_state()->media_factory()->CreateMediaPlayer(
388 frame, url, client, initial_cdm, frame_tree_manager_->app()->shell()); 398 frame, url, client, encrypted_client, initial_cdm,
399 frame_tree_manager_->app()->shell());
389 } 400 }
390 401
391 blink::WebFrame* Frame::createChildFrame(blink::WebLocalFrame* parent, 402 blink::WebFrame* Frame::createChildFrame(blink::WebLocalFrame* parent,
392 blink::WebTreeScopeType scope, 403 blink::WebTreeScopeType scope,
393 const blink::WebString& frame_name, 404 const blink::WebString& frame_name,
394 blink::WebSandboxFlags sandbox_flags) { 405 blink::WebSandboxFlags sandbox_flags) {
395 DCHECK(IsLocal()); // Can't create children of remote frames. 406 DCHECK(IsLocal()); // Can't create children of remote frames.
396 DCHECK_EQ(parent, web_frame_); 407 DCHECK_EQ(parent, web_frame_);
397 DCHECK(view_); // If we're local we have to have a view. 408 DCHECK(view_); // If we're local we have to have a view.
398 // Create the view that will house the frame now. We embed once we know the 409 // Create the view that will house the frame now. We embed once we know the
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 512
502 void Frame::reload(bool ignore_cache, bool is_client_redirect) { 513 void Frame::reload(bool ignore_cache, bool is_client_redirect) {
503 NOTIMPLEMENTED(); 514 NOTIMPLEMENTED();
504 } 515 }
505 516
506 void Frame::forwardInputEvent(const blink::WebInputEvent* event) { 517 void Frame::forwardInputEvent(const blink::WebInputEvent* event) {
507 NOTIMPLEMENTED(); 518 NOTIMPLEMENTED();
508 } 519 }
509 520
510 } // namespace mojo 521 } // namespace mojo
OLDNEW
« no previous file with comments | « components/html_viewer/frame.h ('k') | components/html_viewer/html_document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698