Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names.

Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names.

Committed: https://skia.googlesource.com/skia/+/bb106b5f6ee18f7453b63f3a95f421b60a957f39

Committed: https://skia.googlesource.com/skia/+/6a44c6a7d89b748fb040d41697a337d357d7fa22

[bsalomon, 2015-05-18 18:43:22]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2015-05-18 18:43:23]

code shuffle/rename

[egdaniel, 2015-05-18 19:07:14]

lgtm with one question

https://codereview.chromium.org/1132093004/diff/20001/include/gpu/GrXferProce...
File include/gpu/GrXferProcessor.h (right):

https://codereview.chromium.org/1132093004/diff/20001/include/gpu/GrXferProce...
include/gpu/GrXferProcessor.h:338: SkIPoint                fDstTextureOffset;
Do we want to keep saving the Offset and Texture separately or just keep a
DstTexture?

[bsalomon, 2015-05-18 19:08:46]

On 2015/05/18 19:07:14, egdaniel wrote:
> lgtm with one question
> 
>
https://codereview.chromium.org/1132093004/diff/20001/include/gpu/GrXferProce...
> File include/gpu/GrXferProcessor.h (right):
> 
>
https://codereview.chromium.org/1132093004/diff/20001/include/gpu/GrXferProce...
> include/gpu/GrXferProcessor.h:338: SkIPoint                fDstTextureOffset;
> Do we want to keep saving the Offset and Texture separately or just keep a
> DstTexture?

Not sure yet.... I'm planning to shuffle when the copy occurs, so can revisit as
I go.

[bsalomon, 2015-05-22 18:43:25]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-05-22 18:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1132093004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-22 18:43:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132093004/40001

[commit-bot: I haz the power, 2015-05-22 18:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-22 18:45:24]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bsalomon, 2015-05-22 19:01:00]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-05-22 19:01:00]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1132093004/#ps60001
(title: "rebase again")

[commit-bot: I haz the power, 2015-05-22 19:01:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132093004/60001

[commit-bot: I haz the power, 2015-05-22 19:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-22 19:03:15]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[bsalomon, 2015-05-22 21:25:35]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-05-22 21:25:36]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1132093004/#ps100001
(title: "rebase again")

[commit-bot: I haz the power, 2015-05-22 21:25:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132093004/100001

[commit-bot: I haz the power, 2015-05-22 21:32:14]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/bb106b5f6ee18f7453b63f3a95f421b60a957f39

[bungeman-skia, 2015-05-22 22:22:14]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1158453004/ by bungeman@google.com.

The reason for reverting is: This is asserting on GTX660 bots with '!dst'. This
may just be catching an existing issue.

https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GP...

https://build.chromium.org/p/client.skia/builders/Test-Win7-MSVC-ShuttleA-GPU...

https://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU...

.

[bsalomon, 2015-05-26 16:35:33]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-05-26 16:35:34]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1132093004/#ps120001
(title: "remove asserts")

[commit-bot: I haz the power, 2015-05-26 16:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132093004/120001

[commit-bot: I haz the power, 2015-05-26 16:49:08]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/6a44c6a7d89b748fb040d41697a337d357d7fa22