Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131723005: Fixed Cache Storage inspector blank cells, updated tests (Closed)

Created:
5 years, 7 months ago by dmurph
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixed Cache Storage inspector blank cells, updated tests R=pfeldman@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195228

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed custom cell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -54 lines) Patch
M LayoutTests/http/tests/inspector/cache-storage/cache-data-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/cache-storage/cache-deletion-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/cache-storage/cache-entry-deletion-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js View 1 chunk +10 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 1 2 chunks +2 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dmurph
Hello Pavel, PTAL at this change, it fixes the CacheStorage grid cells from being blank ...
5 years, 7 months ago (2015-05-12 05:25:46 UTC) #1
pfeldman
https://codereview.chromium.org/1131723005/diff/1/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js File Source/devtools/front_end/resources/ServiceWorkerCacheViews.js (right): https://codereview.chromium.org/1131723005/diff/1/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js#newcode170 Source/devtools/front_end/resources/ServiceWorkerCacheViews.js:170: WebInspector.SWCacheDataGridNode = function(data) There are no overrides. Drop the ...
5 years, 7 months ago (2015-05-12 05:28:53 UTC) #2
dmurph
https://codereview.chromium.org/1131723005/diff/1/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js File Source/devtools/front_end/resources/ServiceWorkerCacheViews.js (right): https://codereview.chromium.org/1131723005/diff/1/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js#newcode170 Source/devtools/front_end/resources/ServiceWorkerCacheViews.js:170: WebInspector.SWCacheDataGridNode = function(data) On 2015/05/12 at 05:28:53, pfeldman_ooo_may11 wrote: ...
5 years, 7 months ago (2015-05-12 05:33:50 UTC) #3
pfeldman
lgtm
5 years, 7 months ago (2015-05-12 05:39:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131723005/20001
5 years, 7 months ago (2015-05-12 05:44:30 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 07:01:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195228

Powered by Google App Engine
This is Rietveld 408576698