Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: Source/devtools/front_end/resources/ServiceWorkerCacheViews.js

Issue 1131723005: Fixed Cache Storage inspector blank cells, updated tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed custom cell Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
diff --git a/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js b/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
index 38cafb919e169de4662d9621aa44499318dbb2c4..d702a790255f4a720bf695e4bab2c940d1e9dc9b 100644
--- a/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
+++ b/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
@@ -112,7 +112,8 @@ WebInspector.ServiceWorkerCacheView.prototype = {
data["number"] = i + skipCount;
data["request"] = entries[i].request;
data["response"] = entries[i].response;
- var node = new WebInspector.SWCacheDataGridNode(data);
+ var node = new WebInspector.DataGridNode(data);
+ node.selectable = true;
this._dataGrid.rootNode().appendChild(node);
}
this._pageBackButton.setEnabled(!!skipCount);
@@ -161,40 +162,3 @@ WebInspector.ServiceWorkerCacheView.prototype = {
__proto__: WebInspector.VBox.prototype
}
-
-/**
- * @constructor
- * @extends {WebInspector.DataGridNode}
- * @param {!Object.<string, *>} data
- */
-WebInspector.SWCacheDataGridNode = function(data)
-{
- WebInspector.DataGridNode.call(this, data, false);
- this.selectable = true;
-}
-
-WebInspector.SWCacheDataGridNode.prototype = {
- /**
- * @override
- * @return {!Element}
- */
- createCell: function(columnIdentifier)
- {
- var cell = WebInspector.DataGridNode.prototype.createCell.call(this, columnIdentifier);
- var value = this.data[columnIdentifier];
-
- switch (columnIdentifier) {
- case "request":
- case "response":
- cell.removeChildren();
- var objectElement = WebInspector.ObjectPropertiesSection.defaultObjectPresentation(value, true);
- cell.appendChild(objectElement);
- break;
- default:
- }
-
- return cell;
- },
-
- __proto__: WebInspector.DataGridNode.prototype
-}
« no previous file with comments | « LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698