LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js - Issue 1131723005: Fixed Cache Storage inspector blank cells, updated tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

Issue 1131723005: Fixed Cache Storage inspector blank cells, updated tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed custom cell Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/cache-storage/cache-entry-deletion-expected.txt ('k') | Source/devtools/front_end/resources/ServiceWorkerCacheViews.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

diff --git a/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js b/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

index 56bec5959143807e3ba8460d18d9fa742f84f579..a65d4375af8e9e2839b229cf64cad3ac7247ca64 100644

--- a/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

+++ b/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

@@ -42,8 +42,16 @@ InspectorTest.dumpCacheTree = function()

nextOrResolve();

return;

}

- for (var entry of view._entries)

- InspectorTest.addResult(" '" + entry.request + "': '" + entry.response + "'");

+ var dataGrid = view._dataGrid;

+ for (var node of dataGrid.rootNode().children) {

+ var entries = [];

+ for (var j = 0; j < node.element().children.length; j++) {

+ var td = node.element().children[j];

+ if (td.textContent)

+ entries.push(td.textContent);

+ }

+ InspectorTest.addResult(" " + entries.join(", "));

+ }

nextOrResolve();

}