Devtools: [CustomFormatter] Add context menu to disassemble custom previews

Devtools: [CustomFormatter] Add context menu to disassemble custom previews

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194934

[sergeyv, 2015-04-28 16:13:46]

sergeyv@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-04-28 16:20:40]

https://codereview.chromium.org/1107233003/diff/1/Source/devtools/front_end/c...
File Source/devtools/front_end/components/CustomPreviewSection.js (right):

https://codereview.chromium.org/1107233003/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/components/CustomPreviewSection.js:68:
contextMenu.appendItem(WebInspector.UIString.capitalize("Disassemble in ^native
JS ^object" ), this._disassemble.bind(this));
Show as JavaScript Object

https://codereview.chromium.org/1107233003/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/components/CustomPreviewSection.js:99:
shadowRoot.appendChild(WebInspector.ObjectPropertiesSection.createValueElement(object,
false));
should createValueElement add objectValue on its own? Also, this looks like a
standard ObjectPropertiesSection application. Why is it so involved?

[pfeldman, 2015-04-28 16:34:18]

lgtm

[sergeyv, 2015-05-05 10:33:33]

please take a look once again

[pfeldman, 2015-05-05 14:10:57]

lgtm

[sergeyv, 2015-05-05 15:54:47]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2015-05-05 15:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107233003/20001

[commit-bot: I haz the power, 2015-05-05 18:41:00]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194934

[dmurph, 2015-05-12 04:27:24]

On 2015/05/05 at 18:41:00, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194934

This broke the the Cache Storage view.  The value is not an 'ObjectProperties'
value or a 'RemoteObject', it's just a string.

Can you please remove this change from the ServiceWorkerCacheViews.js?

[dmurph, 2015-05-12 04:29:42]

On 2015/05/12 at 04:27:24, dmurph wrote:
> On 2015/05/05 at 18:41:00, commit-bot wrote:
> > Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194934
> 
> This broke the the Cache Storage view.  The value is not an 'ObjectProperties'
value or a 'RemoteObject', it's just a string.
> 
> Can you please remove this change from the ServiceWorkerCacheViews.js?

Actually, I'll make the patch.

[dmurph, 2015-05-12 05:25:54]

On 2015/05/12 at 04:29:42, dmurph wrote:
> On 2015/05/12 at 04:27:24, dmurph wrote:
> > On 2015/05/05 at 18:41:00, commit-bot wrote:
> > > Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194934
> > 
> > This broke the the Cache Storage view.  The value is not an
'ObjectProperties' value or a 'RemoteObject', it's just a string.
> > 
> > Can you please remove this change from the ServiceWorkerCacheViews.js?
> 
> Actually, I'll make the patch.

Change here:
https://codereview.chromium.org/1131723005