Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1131113005: Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets BUG=487800 Committed: https://skia.googlesource.com/skia/+/6bad28de5268cbcf504799782477a7e33991610c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M tools/skp/page_sets/other/CRASHING-skia_vnexpress_nexus10.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_css3gradients_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_digg_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_espn_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gmail_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gmailthread_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googlehome_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_mozilla_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_nytimes_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_pokemonwiki_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_pravda_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_samoasvg_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_theverge_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_tigersvg_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_ugamsolutions_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_unicodetable_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_wowwiki_desktop.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
nednguyen
5 years, 7 months ago (2015-05-13 21:40:20 UTC) #2
nednguyen
On 2015/05/13 21:40:20, nednguyen (slow review) wrote: PTAL
5 years, 7 months ago (2015-05-14 21:33:38 UTC) #3
bsalomon
Adding Ravi.
5 years, 7 months ago (2015-05-15 00:52:55 UTC) #5
rmistry
LGTM Thanks for making these changes to the Skia page sets! They are normally unfortunately ...
5 years, 7 months ago (2015-05-15 10:46:29 UTC) #6
nednguyen
On 2015/05/15 10:46:29, rmistry wrote: > LGTM > > Thanks for making these changes to ...
5 years, 7 months ago (2015-05-15 18:38:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131113005/1
5 years, 7 months ago (2015-05-15 18:39:11 UTC) #9
nednguyen
+Annie: this raises the question of keeping track of who are using telemetry framework.
5 years, 7 months ago (2015-05-15 18:39:20 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-16 22:47:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6bad28de5268cbcf504799782477a7e33991610c

Powered by Google App Engine
This is Rietveld 408576698