tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json - Issue 1131113005: Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json

Issue 1131113005: Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/skp/page_sets/other/CRASHING-skia_vnexpress_nexus10.json ('k') | tools/skp/page_sets/skia_css3gradients_desktop.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json

diff --git a/tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json b/tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json

index e31ec41225d2d8f3a04c889344ca4dd7b5614632..2cf217913735d340ea523a6921833fb69c0077b7 100644

--- a/tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json

+++ b/tools/skp/page_sets/other/CRASHING-skia_wikipedia_galaxynexus.json

@@ -19,7 +19,7 @@ class SkiaBuildbotDesktopPage(page_module.Page):

self.archive_data_file = 'data/skia_wikipedia_galaxynexus.json'

def RunNavigateSteps(self, action_runner):

- action_runner.NavigateToPage(self)

+ action_runner.Navigate(self.url)

action_runner.Wait(5)