tools/skp/page_sets/skia_nytimes_desktop.py - Issue 1131113005: Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/page_sets/skia_nytimes_desktop.py

Issue 1131113005: Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/skp/page_sets/skia_nytimes_desktop.py

diff --git a/tools/skp/page_sets/skia_nytimes_desktop.py b/tools/skp/page_sets/skia_nytimes_desktop.py

index d8f9ed7f089aae3d766718513147310f98e00432..3f72b91cfd462fd3043a01ef52d0495602022cbe 100644

--- a/tools/skp/page_sets/skia_nytimes_desktop.py

+++ b/tools/skp/page_sets/skia_nytimes_desktop.py

@@ -19,7 +19,7 @@ class SkiaBuildbotDesktopPage(page_module.Page):

self.archive_data_file = 'data/skia_nytimes_desktop.json'

def RunNavigateSteps(self, action_runner):

- action_runner.NavigateToPage(self)

+ action_runner.Navigate(self.url)

action_runner.Wait(15)

« no previous file with comments | « tools/skp/page_sets/skia_mozilla_nexus10.py ('k') | tools/skp/page_sets/skia_pokemonwiki_desktop.py » ('j') | no next file with comments »