Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: tools/skp/page_sets/skia_wowwiki_desktop.py

Issue 1131113005: Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/skp/page_sets/skia_unicodetable_desktop.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 # pylint: disable=W0401,W0614 4 # pylint: disable=W0401,W0614
5 5
6 6
7 from telemetry.page import page as page_module 7 from telemetry.page import page as page_module
8 from telemetry.page import page_set as page_set_module 8 from telemetry.page import page_set as page_set_module
9 9
10 10
11 class SkiaBuildbotDesktopPage(page_module.Page): 11 class SkiaBuildbotDesktopPage(page_module.Page):
12 12
13 def __init__(self, url, page_set): 13 def __init__(self, url, page_set):
14 super(SkiaBuildbotDesktopPage, self).__init__( 14 super(SkiaBuildbotDesktopPage, self).__init__(
15 url=url, 15 url=url,
16 page_set=page_set, 16 page_set=page_set,
17 credentials_path='data/credentials.json') 17 credentials_path='data/credentials.json')
18 self.user_agent_type = 'desktop' 18 self.user_agent_type = 'desktop'
19 self.archive_data_file = 'data/skia_wowwiki_desktop.json' 19 self.archive_data_file = 'data/skia_wowwiki_desktop.json'
20 20
21 def RunNavigateSteps(self, action_runner): 21 def RunNavigateSteps(self, action_runner):
22 action_runner.NavigateToPage(self) 22 action_runner.Navigate(self.url)
23 action_runner.Wait(25) 23 action_runner.Wait(25)
24 24
25 25
26 class SkiaWowwikiDesktopPageSet(page_set_module.PageSet): 26 class SkiaWowwikiDesktopPageSet(page_set_module.PageSet):
27 27
28 """ Pages designed to represent the median, not highly optimized web """ 28 """ Pages designed to represent the median, not highly optimized web """
29 29
30 def __init__(self): 30 def __init__(self):
31 super(SkiaWowwikiDesktopPageSet, self).__init__( 31 super(SkiaWowwikiDesktopPageSet, self).__init__(
32 user_agent_type='desktop', 32 user_agent_type='desktop',
33 archive_data_file='data/skia_wowwiki_desktop.json') 33 archive_data_file='data/skia_wowwiki_desktop.json')
34 34
35 urls_list = [ 35 urls_list = [
36 # Why: http://code.google.com/p/chromium/issues/detail?id=136555 36 # Why: http://code.google.com/p/chromium/issues/detail?id=136555
37 'http://www.wowwiki.com/World_of_Warcraft:_Mists_of_Pandaria', 37 'http://www.wowwiki.com/World_of_Warcraft:_Mists_of_Pandaria',
38 ] 38 ]
39 39
40 for url in urls_list: 40 for url in urls_list:
41 self.AddUserStory(SkiaBuildbotDesktopPage(url, self)) 41 self.AddUserStory(SkiaBuildbotDesktopPage(url, self))
OLDNEW
« no previous file with comments | « tools/skp/page_sets/skia_unicodetable_desktop.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698