ash : introduce second SessionStateController implementation.

Second SessionStateController implementation (just a copy), command-line switches, removed CancelLockWithOtherAnimation(), several constant renames in SessionStateAnimator.

Includes https://codereview.chromium.org/11238058/ fix.

BUG=138171, 139461
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163645

[Daniel Erat, 2012-10-23 15:52:43]

LGTM with a few comments

http://codereview.chromium.org/11230050/diff/1/ash/wm/power_button_controller...
File ash/wm/power_button_controller_unittest.cc (right):

http://codereview.chromium.org/11230050/diff/1/ash/wm/power_button_controller...
ash/wm/power_button_controller_unittest.cc:66: state_controller_ =
reinterpret_cast<SessionStateControllerImpl*>(
shouldn't you be forcing the kAshNewLockAnimationsEnabled flag off (assuming
that that's possible) first?  this seems unsafe otherwise.

can you static_cast instead of reinterpret_cast here?

http://codereview.chromium.org/11230050/diff/1/ash/wm/session_state_controlle...
File ash/wm/session_state_controller.cc (right):

http://codereview.chromium.org/11230050/diff/1/ash/wm/session_state_controlle...
ash/wm/session_state_controller.cc:31:
SessionStateController::SessionStateController() :
nit: move ':' to the beginning of the next line:

SessionStateController::SessionStateController()
    : animator_(new internal::SessionStateAnimator()) {

[Denis Kuznetsov (DE-MUC), 2012-10-23 17:06:39]

https://codereview.chromium.org/11230050/diff/1/ash/wm/power_button_controlle...
File ash/wm/power_button_controller_unittest.cc (right):

https://codereview.chromium.org/11230050/diff/1/ash/wm/power_button_controlle...
ash/wm/power_button_controller_unittest.cc:66: state_controller_ =
reinterpret_cast<SessionStateControllerImpl*>(
On 2012/10/23 15:52:43, Daniel Erat wrote:
> shouldn't you be forcing the kAshNewLockAnimationsEnabled flag off (assuming
> that that's possible) first?  this seems unsafe otherwise.
> 
> can you static_cast instead of reinterpret_cast here?
There is no method to remove some flag from command line, but I've added
explicit check.

https://codereview.chromium.org/11230050/diff/1/ash/wm/session_state_controll...
File ash/wm/session_state_controller.cc (right):

https://codereview.chromium.org/11230050/diff/1/ash/wm/session_state_controll...
ash/wm/session_state_controller.cc:31:
SessionStateController::SessionStateController() :
On 2012/10/23 15:52:43, Daniel Erat wrote:
> nit: move ':' to the beginning of the next line:
> 
> SessionStateController::SessionStateController()
>     : animator_(new internal::SessionStateAnimator()) {

Done.

[commit-bot: I haz the power, 2012-10-23 17:13:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11230050/7001

[commit-bot: I haz the power, 2012-10-23 17:13:37]

Presubmit check for 11230050-7001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 2.4s to calculate.

[Denis Kuznetsov (DE-MUC), 2012-10-23 17:16:25]

Scott, please review chrome/* part (actually, just a new switch).

[Denis Kuznetsov (DE-MUC), 2012-10-23 17:18:40]

On 2012/10/23 17:16:25, Denis Kuznetsov wrote:
> Scott, please review chrome/* part (actually, just a new switch).

Please, LGTM & CQ it.

[sky, 2012-10-23 17:35:58]

LGTM

[commit-bot: I haz the power, 2012-10-23 17:36:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11230050/7001

[commit-bot: I haz the power, 2012-10-23 19:39:05]

Change committed as 163645