Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122643005: Make drawImage a virtual on SkDevice (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make drawImage a virtual on SkDevice Now with patch for SkDeferredCanvas This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57. BUG=skia: Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : now with Pipe patches #

Total comments: 18

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -78 lines) Patch
M include/core/SkDevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +0 lines, -13 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +51 lines, -5 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download
M src/core/SkPaintPriv.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 2 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 2 chunks +42 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 2 7 chunks +46 lines, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 7 chunks +89 lines, -5 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 3 5 chunks +52 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
reed1
ptal @ deferredcanvas and pipe changes
5 years, 7 months ago (2015-05-05 18:28:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122643005/40001
5 years, 7 months ago (2015-05-05 18:30:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 18:44:47 UTC) #6
robertphillips
lgtm + nits & questions https://codereview.chromium.org/1122643005/diff/40001/src/core/SkDevice.cpp File src/core/SkDevice.cpp (right): https://codereview.chromium.org/1122643005/diff/40001/src/core/SkDevice.cpp#newcode167 src/core/SkDevice.cpp:167: Should this #include go ...
5 years, 7 months ago (2015-05-05 18:47:56 UTC) #7
mtklein
https://codereview.chromium.org/1122643005/diff/40001/src/utils/SkDeferredCanvas.cpp File src/utils/SkDeferredCanvas.cpp (right): https://codereview.chromium.org/1122643005/diff/40001/src/utils/SkDeferredCanvas.cpp#newcode43 src/utils/SkDeferredCanvas.cpp:43: // Here we detect the case where the shader ...
5 years, 7 months ago (2015-05-05 18:50:01 UTC) #8
reed1
https://codereview.chromium.org/1122643005/diff/40001/src/core/SkDevice.cpp File src/core/SkDevice.cpp (right): https://codereview.chromium.org/1122643005/diff/40001/src/core/SkDevice.cpp#newcode167 src/core/SkDevice.cpp:167: On 2015/05/05 18:47:56, robertphillips wrote: > Should this #include ...
5 years, 7 months ago (2015-05-05 19:45:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122643005/60001
5 years, 7 months ago (2015-05-05 19:45:36 UTC) #12
mtklein
lgtm
5 years, 7 months ago (2015-05-05 19:48:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122643005/60001
5 years, 7 months ago (2015-05-05 19:54:15 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
5 years, 7 months ago (2015-05-05 19:54:48 UTC) #17
reed2
5 years, 7 months ago (2015-05-06 00:30:11 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1124003002/ by reed@chromium.org.

The reason for reverting is: speculative to see if it unblocks DEPS roll.

Powered by Google App Engine
This is Rietveld 408576698