win: Ref-counted classes should have non-public destructors.

win: Ref-counted classes should have non-public destructors.

BUG=123295, 467287
TBR=avi,rsleevi,kbr,grt

Committed: https://crrev.com/efa363a5b868a17049852fa9cd86679120041853
Cr-Commit-Position: refs/heads/master@{#328040}

[Nico, 2015-05-02 00:56:52]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nico, 2015-05-02 00:56:53]

This fixes all remaining ref-counted diags (except for the one fixed by
ttps://codereview.chromium.org/1123613002/)

[dcheng, 2015-05-02 01:15:08]

lgtm

https://codereview.chromium.org/1120203004/diff/1/ui/gl/gl_context_wgl.cc
File ui/gl/gl_context_wgl.cc (right):

https://codereview.chromium.org/1120203004/diff/1/ui/gl/gl_context_wgl.cc#new...
ui/gl/gl_context_wgl.cc:135: return GLContext::GetExtensions() + " " +
extensions;
I wonder how much code bloat we have from string's operator+

[dcheng, 2015-05-02 01:15:12]

lgtm

[Nico, 2015-05-02 01:24:23]

thakis@chromium.org changed reviewers:
+ avi@chromium.org, grt@chromium.org, kbr@chromium.org, rsleevi@chromium.org

[Nico, 2015-05-02 01:24:24]

tbr'ing as it's a boring cleanup cl

avi: content/
rsleevi: net/
kbr: ui/gl
grt: win8/

[Nico, 2015-05-02 01:24:30]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-05-02 01:24:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1120203004/1

[Ryan Sleevi, 2015-05-02 01:28:26]

LGTM % nits

https://codereview.chromium.org/1120203004/diff/1/net/proxy/dhcp_proxy_script...
File net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc (right):

https://codereview.chromium.org/1120203004/diff/1/net/proxy/dhcp_proxy_script...
net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc:85:
~DelayingDhcpQuery() {}
no "override" ?

https://codereview.chromium.org/1120203004/diff/1/win8/viewer/metro_viewer_pr...
File win8/viewer/metro_viewer_process_host.h (right):

https://codereview.chromium.org/1120203004/diff/1/win8/viewer/metro_viewer_pr...
win8/viewer/metro_viewer_process_host.h:194: ~InternalMessageFilter();
no override?

[commit-bot: I haz the power, 2015-05-02 01:28:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-02 01:29:55]

Patchset 1 (id:??) landed as
https://crrev.com/efa363a5b868a17049852fa9cd86679120041853
Cr-Commit-Position: refs/heads/master@{#328040}

[Nico, 2015-05-02 02:01:42]

Good catch, I bet that'll cause a warning for that. Will send you a
follow-up.
On May 1, 2015 6:28 PM, <rsleevi@chromium.org> wrote:

> LGTM % nits
>
>
>
>
https://codereview.chromium.org/1120203004/diff/1/net/proxy/dhcp_proxy_script...
> File net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc
> (right):
>
>
>
https://codereview.chromium.org/1120203004/diff/1/net/proxy/dhcp_proxy_script...
> net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc:85:
> ~DelayingDhcpQuery() {}
> no "override" ?
>
>
>
https://codereview.chromium.org/1120203004/diff/1/win8/viewer/metro_viewer_pr...
> File win8/viewer/metro_viewer_process_host.h (right):
>
>
>
https://codereview.chromium.org/1120203004/diff/1/win8/viewer/metro_viewer_pr...
> win8/viewer/metro_viewer_process_host.h:194: ~InternalMessageFilter();
> no override?
>
> https://codereview.chromium.org/1120203004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Avi (use Gerrit), 2015-05-02 02:22:40]

lgtm

stampity stamp

[grt (UTC plus 2), 2015-05-02 12:30:37]

lgtm

[Ken Russell (switch to Gerrit), 2015-05-04 21:49:41]

ui/gl lgtm