net/proxy/dhcp_proxy_script_fetcher_win.h - Issue 1120203004: win: Ref-counted classes should have non-public destructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_fetcher_win.h

Issue 1120203004: win: Ref-counted classes should have non-public destructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc ('K') | « net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc ('k') | net/proxy/dhcp_proxy_script_fetcher_win.cc » ('j') | ui/gl/gl_context_wgl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/dhcp_proxy_script_fetcher_win.h

diff --git a/net/proxy/dhcp_proxy_script_fetcher_win.h b/net/proxy/dhcp_proxy_script_fetcher_win.h

index d490805c2b7aeac0b01abcd9875dcebc9b18b74a..fbe4a61638e41a68360f6cdd99fe1cf240046590 100644

--- a/net/proxy/dhcp_proxy_script_fetcher_win.h

+++ b/net/proxy/dhcp_proxy_script_fetcher_win.h

@@ -63,7 +63,6 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptFetcherWin

: public base::RefCountedThreadSafe<AdapterQuery> {

public:

AdapterQuery();

- virtual ~AdapterQuery();

// This is the method that runs on the worker pool thread.

void GetCandidateAdapterNames();

@@ -77,6 +76,9 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptFetcherWin

virtual bool ImplGetCandidateAdapterNames(

std::set<std::string>* adapter_names);

+ friend class base::RefCountedThreadSafe<AdapterQuery>;

+ virtual ~AdapterQuery();

private:

// This is constructed on the originating thread, then used on the

// worker thread, then used again on the originating thread only when