Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc

Issue 1120203004: win: Ref-counted classes should have non-public destructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc
diff --git a/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc b/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc
index 103312651c6335ca02b4dc7431e40a9b6a852138..59927dc2cb6d568ee911532beb93584d905bac01 100644
--- a/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc
+++ b/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc
@@ -157,15 +157,16 @@ class DelayingDhcpProxyScriptAdapterFetcher
class DelayingDhcpQuery : public DhcpQuery {
public:
- explicit DelayingDhcpQuery()
- : DhcpQuery() {
- }
+ explicit DelayingDhcpQuery() : DhcpQuery() {}
std::string ImplGetPacURLFromDhcp(
const std::string& adapter_name) override {
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(20));
return DhcpQuery::ImplGetPacURLFromDhcp(adapter_name);
}
+
+ private:
+ ~DelayingDhcpQuery() override {}
};
DhcpQuery* ImplCreateDhcpQuery() override {
@@ -269,8 +270,6 @@ class MockDhcpProxyScriptFetcherWin : public DhcpProxyScriptFetcherWin {
MockAdapterQuery() {
}
- ~MockAdapterQuery() override {}
-
bool ImplGetCandidateAdapterNames(
std::set<std::string>* adapter_names) override {
adapter_names->insert(
@@ -279,6 +278,9 @@ class MockDhcpProxyScriptFetcherWin : public DhcpProxyScriptFetcherWin {
}
std::vector<std::string> mock_adapter_names_;
+
+ private:
+ ~MockAdapterQuery() override {}
};
MockDhcpProxyScriptFetcherWin(URLRequestContext* context)

Powered by Google App Engine
This is Rietveld 408576698