net/proxy/dhcp_proxy_script_adapter_fetcher_win.h - Issue 1120203004: win: Ref-counted classes should have non-public destructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_adapter_fetcher_win.h

Issue 1120203004: win: Ref-counted classes should have non-public destructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/font_cache_dispatcher_win.cc ('k') | net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc » ('j') | net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/dhcp_proxy_script_adapter_fetcher_win.h

diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h

index 70bc8e2d4ed817c7f253a9d2d1c62644ca521aa9..30dcda2bde6f872fcb7859187fd6006866312db9 100644

--- a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h

+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h

@@ -120,7 +120,6 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptAdapterFetcher

: public base::RefCountedThreadSafe<DhcpQuery> {

public:

DhcpQuery();

- virtual ~DhcpQuery();

// This method should run on a worker pool thread, via PostTaskAndReply.

// After it has run, the |url()| method on this object will return the

@@ -134,6 +133,9 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptAdapterFetcher

// Virtual method introduced to allow unit testing.

virtual std::string ImplGetPacURLFromDhcp(const std::string& adapter_name);

+ friend class base::RefCountedThreadSafe<DhcpQuery>;

+ virtual ~DhcpQuery();

private:

// The URL retrieved for the given adapter.

std::string url_;