Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles. (Closed)

Created:
5 years, 7 months ago by yzshen1
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove some InterfacePtr<> methods which directly deal with message pipe handles. Users should use the corresponding methods dealing with InterfacePtrInfo<>. BUG=None TEST=None R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5bae22347b9d4685af51f73ae665be703247e5ca

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -76 lines) Patch
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M examples/indirect_service/indirect_service_demo.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M examples/spinning_cube/gles2_client_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/gpu/gl_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/application_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/connect.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +6 lines, -28 lines 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/dart/content_handler_app_service_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/echo_apptest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/surfaces/display_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M shell/application_manager/application_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M shell/child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/shell_test_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M sky/shell/ui/internals.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/viewer/internals.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
yzshen1
Hi, James. Would you please take a look? Thanks!
5 years, 7 months ago (2015-04-30 22:56:43 UTC) #2
jamesr
Are the chromium users of the deprecated versions all gone by now? https://codereview.chromium.org/1118843003/diff/1/sky/engine/core/html/HTMLIFrameElement.cpp File sky/engine/core/html/HTMLIFrameElement.cpp ...
5 years, 7 months ago (2015-04-30 23:00:46 UTC) #3
jamesr
lgtm if the build will stay green
5 years, 7 months ago (2015-04-30 23:01:22 UTC) #4
yzshen1
> Are the chromium users of the deprecated versions all gone by now? There are ...
5 years, 7 months ago (2015-04-30 23:21:56 UTC) #5
yzshen1
5 years, 7 months ago (2015-05-04 21:47:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5bae22347b9d4685af51f73ae665be703247e5ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698