Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/interface_request.h ('k') | mojo/public/cpp/bindings/tests/validation_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
index 182f51c1315ed16b67e77cece78f7527d60feac8..09e481242cfd266eb8c8e1788b5d3a9df4a93899 100644
--- a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
@@ -266,7 +266,7 @@ TEST_F(InterfacePtrTest, Resettable) {
// Save this so we can test it later.
Handle handle = pipe.handle0.get();
- a = MakeProxy<math::Calculator>(pipe.handle0.Pass());
+ a = MakeProxy(InterfacePtrInfo<math::Calculator>(pipe.handle0.Pass(), 0u));
EXPECT_FALSE(!a);
@@ -284,7 +284,7 @@ TEST_F(InterfacePtrTest, BindInvalidHandle) {
EXPECT_FALSE(ptr.get());
EXPECT_FALSE(ptr);
- ptr.Bind(ScopedMessagePipeHandle());
+ ptr.Bind(InterfacePtrInfo<math::Calculator>());
EXPECT_FALSE(ptr.get());
EXPECT_FALSE(ptr);
}
@@ -486,7 +486,7 @@ TEST(StrongConnectorTest, Math) {
&destroyed);
math::CalculatorPtr calc;
- calc.Bind(pipe.handle1.Pass());
+ calc.Bind(InterfacePtrInfo<math::Calculator>(pipe.handle1.Pass(), 0u));
{
// Suppose this is instantiated in a process that has the other end of the
@@ -556,7 +556,7 @@ TEST(WeakConnectorTest, Math) {
WeakMathCalculatorImpl impl(pipe.handle0.Pass(), &error_received, &destroyed);
math::CalculatorPtr calc;
- calc.Bind(pipe.handle1.Pass());
+ calc.Bind(InterfacePtrInfo<math::Calculator>(pipe.handle1.Pass(), 0u));
{
// Suppose this is instantiated in a process that has the other end of the
« no previous file with comments | « mojo/public/cpp/bindings/interface_request.h ('k') | mojo/public/cpp/bindings/tests/validation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698