mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc - Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/validation_unittest.cc ('k') | services/dart/content_handler_app_service_connector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

diff --git a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

index 77dc293fe019b216da3b6d25a101c9fa1bedeac5..c4aea7013c8bc57503c8db9d2c3f325dee054bc0 100644

--- a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

+++ b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

@@ -291,7 +291,8 @@ void ViewManagerClientImpl::OnEmbed(

root_ = AddViewToViewManager(this, nullptr, root_data);

root_->AddObserver(new RootObserver(root_));

- window_manager_.Bind(window_manager_pipe.Pass());

+ window_manager_.Bind(

+ InterfacePtrInfo<WindowManager>(window_manager_pipe.Pass(), 0u));

WindowManagerObserverPtr observer;

wm_observer_binding_.Bind(GetProxy(&observer));

// binding to |this| is safe here as |window_manager_| is bound to our

« no previous file with comments | « mojo/public/cpp/bindings/tests/validation_unittest.cc ('k') | services/dart/content_handler_app_service_connector.cc » ('j') | no next file with comments »