Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/shell_test_base.h ('k') | sky/shell/ui/engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index edbbc748a1b09dd3326a4d56259dab3c4bd63897..c22e5bb126c147ec0b7ca3b541ec010cc1a5da29 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -82,11 +82,13 @@ PassRefPtr<DartValue> HTMLIFrameElement::takeExposedServicesHandle(DartState*)
void HTMLIFrameElement::embedViewManagerClient(RefPtr<DartValue> client)
{
- if (!m_contentView)
- return;
+ if (!m_contentView)
+ return;
- m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(
- DartConverter<mojo::ScopedMessagePipeHandle>::FromDart(client->dart_value())));
+ mojo::ScopedMessagePipeHandle handle = DartConverter<mojo::ScopedMessagePipeHandle>::FromDart(client->dart_value());
+ mojo::ViewManagerClientPtr client_ptr = mojo::MakeProxy(
+ mojo::InterfacePtrInfo<mojo::ViewManagerClient>(handle.Pass(), 0u));
+ m_contentView->Embed(client_ptr.Pass());
}
void HTMLIFrameElement::navigateView()
@@ -105,7 +107,7 @@ void HTMLIFrameElement::navigateView()
m_contentView->Embed(mojo::String::From(url.string().utf8().data()),
mojo::GetProxy(&m_services),
- mojo::MakeProxy<mojo::ServiceProvider>(exposedServicesPipe.handle1.Pass()));
+ mojo::MakeProxy(mojo::InterfacePtrInfo<mojo::ServiceProvider>(exposedServicesPipe.handle1.Pass(), 0u)));
}
}
« no previous file with comments | « shell/shell_test_base.h ('k') | sky/shell/ui/engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698