chrome/browser/spellchecker/feedback_sender.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/feedback_sender.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/srt_fetcher_win.cc ('K') | « chrome/browser/safe_browsing/two_phase_uploader.cc ('k') | chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc » ('j') | chrome/browser/spellchecker/spelling_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/feedback_sender.cc

diff --git a/chrome/browser/spellchecker/feedback_sender.cc b/chrome/browser/spellchecker/feedback_sender.cc

index ab83a50856279d63a4ea2b3dbbf5fb4c2d1dc212..5ed97bb9f9929da961326a12aea562460ab65b9c 100644

--- a/chrome/browser/spellchecker/feedback_sender.cc

+++ b/chrome/browser/spellchecker/feedback_sender.cc

@@ -407,8 +407,9 @@ void FeedbackSender::SendFeedback(const std::vector<Misspelling>& feedback_data,

// The tests use this identifier to mock the URL fetcher.

static const int kUrlFetcherId = 0;

- net::URLFetcher* sender = net::URLFetcher::Create(

- kUrlFetcherId, feedback_service_url_, net::URLFetcher::POST, this);

+ net::URLFetcher* sender =

+ net::URLFetcher::Create(kUrlFetcherId, feedback_service_url_,

+ net::URLFetcher::POST, this).release();

Ryan Sleevi 2015/04/30 18:23:44 line 416

sender->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |

net::LOAD_DO_NOT_SAVE_COOKIES);

sender->SetUploadData("application/json", feedback);