chrome/browser/spellchecker/spelling_service_client.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spelling_service_client.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/feedback_sender.cc ('K') | « chrome/browser/spellchecker/spelling_service_client.h ('k') | chrome/browser/spellchecker/spelling_service_client_unittest.cc » ('j') | chrome/browser/ui/webui/devtools_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spelling_service_client.cc

diff --git a/chrome/browser/spellchecker/spelling_service_client.cc b/chrome/browser/spellchecker/spelling_service_client.cc

index 5808e6f9ecb281f124b9154e6612b66cf9aebb61..7248f8ad6a5d1a9248d44ef5a2192efbca078577 100644

--- a/chrome/browser/spellchecker/spelling_service_client.cc

+++ b/chrome/browser/spellchecker/spelling_service_client.cc

@@ -90,7 +90,7 @@ bool SpellingServiceClient::RequestTextCheck(

api_key.c_str());

GURL url = GURL(kSpellingServiceURL);

- net::URLFetcher* fetcher = CreateURLFetcher(url);

+ net::URLFetcher* fetcher = CreateURLFetcher(url).release();

Ryan Sleevi 2015/04/30 18:23:44 line 98

fetcher->SetRequestContext(context->GetRequestContext());

fetcher->SetUploadData("application/json", request);

fetcher->SetLoadFlags(

@@ -253,6 +253,7 @@ void SpellingServiceClient::OnURLFetchComplete(

callback_data->callback.Run(success, callback_data->text, results);

}

-net::URLFetcher* SpellingServiceClient::CreateURLFetcher(const GURL& url) {

+scoped_ptr<net::URLFetcher> SpellingServiceClient::CreateURLFetcher(

+ const GURL& url) {

return net::URLFetcher::Create(url, net::URLFetcher::POST, this);

}