chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/feedback_sender.cc ('K') | « chrome/browser/spellchecker/feedback_sender.cc ('k') | chrome/browser/spellchecker/spelling_service_client.h » ('j') | chrome/browser/spellchecker/spelling_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

diff --git a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

index daac459f0eecd2ff4e0d3e3ce58378d72cab62a9..b2e73c49c9bf308fb1dc48ed8fb8d1a8530bc526 100644

--- a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

+++ b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

@@ -230,7 +230,7 @@ void SpellcheckHunspellDictionary::DownloadDictionary(GURL url) {

download_status_ = DOWNLOAD_IN_PROGRESS;

FOR_EACH_OBSERVER(Observer, observers_, OnHunspellDictionaryDownloadBegin());

- fetcher_.reset(net::URLFetcher::Create(url, net::URLFetcher::GET, this));

+ fetcher_ = net::URLFetcher::Create(url, net::URLFetcher::GET, this);

fetcher_->SetRequestContext(request_context_getter_);

fetcher_->SetLoadFlags(

net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES);