chrome/browser/safe_browsing/srt_fetcher_win.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/protocol_manager.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_test.cc ('k') | chrome/browser/safe_browsing/two_phase_uploader.cc » ('j') | chrome/browser/spellchecker/feedback_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/srt_fetcher_win.cc

diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.cc b/chrome/browser/safe_browsing/srt_fetcher_win.cc

index bbb40bb7d73f57141585b1bc35b70bbc8bc276cb..e1e70f5786ccc035a96f0c1ffd04bc5ef124e82a 100644

--- a/chrome/browser/safe_browsing/srt_fetcher_win.cc

+++ b/chrome/browser/safe_browsing/srt_fetcher_win.cc

@@ -76,7 +76,7 @@ class SRTFetcher : public net::URLFetcherDelegate {

: url_fetcher_(net::URLFetcher::Create(0,

GURL(GetSRTDownloadURL()),

net::URLFetcher::GET,

- this)) {

+ this).Pass()) {

Ryan Sleevi 2015/04/30 18:23:44 Is the .Pass() needed here for these emplacements?

dtapuska 2015/04/30 19:05:56 Pass() is the safe bet.. I was concerned about com

url_fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE);

url_fetcher_->SetMaxRetriesOn5xx(3);

url_fetcher_->SaveResponseToTemporaryFile(