chrome/browser/intranet_redirect_detector.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/intranet_redirect_detector.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/blacklist_state_fetcher.cc ('K') | « chrome/browser/extensions/webstore_data_fetcher.cc ('k') | chrome/browser/local_discovery/gcd_api_flow_impl.cc » ('j') | chrome/browser/media/webrtc_log_uploader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/intranet_redirect_detector.cc

diff --git a/chrome/browser/intranet_redirect_detector.cc b/chrome/browser/intranet_redirect_detector.cc

index ead733363b5d8103387e3b3d9eb02246dbc02242..1a8795243e107171d701af28a7fc5bc335880cdf 100644

--- a/chrome/browser/intranet_redirect_detector.cc

+++ b/chrome/browser/intranet_redirect_detector.cc

@@ -80,8 +80,9 @@ void IntranetRedirectDetector::FinishSleep() {

for (int j = 0; j < num_chars; ++j)

url_string += ('a' + base::RandInt(0, 'z' - 'a'));

GURL random_url(url_string + '/');

- net::URLFetcher* fetcher = net::URLFetcher::Create(

- random_url, net::URLFetcher::HEAD, this);

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(random_url, net::URLFetcher::HEAD, this)

+ .release();

Ryan Sleevi 2015/04/30 18:23:44 Ditto moving this to line 92

// We don't want these fetches to affect existing state in the profile.

fetcher->SetLoadFlags(net::LOAD_DISABLE_CACHE |

net::LOAD_DO_NOT_SAVE_COOKIES |