chrome/browser/extensions/webstore_data_fetcher.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_data_fetcher.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/blacklist_state_fetcher.cc ('K') | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/intranet_redirect_detector.cc » ('j') | chrome/browser/intranet_redirect_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_data_fetcher.cc

diff --git a/chrome/browser/extensions/webstore_data_fetcher.cc b/chrome/browser/extensions/webstore_data_fetcher.cc

index 0300519cda6e4406ccfdd549fc489c1ecd88a358..0805cae0ae5b8a7ebe5c47beaee4e64d2b85a938 100644

--- a/chrome/browser/extensions/webstore_data_fetcher.cc

+++ b/chrome/browser/extensions/webstore_data_fetcher.cc

@@ -38,8 +38,8 @@ WebstoreDataFetcher::~WebstoreDataFetcher() {}

void WebstoreDataFetcher::Start() {

GURL webstore_data_url(extension_urls::GetWebstoreItemJsonDataURL(id_));

- webstore_data_url_fetcher_.reset(net::URLFetcher::Create(

- webstore_data_url, net::URLFetcher::GET, this));

+ webstore_data_url_fetcher_ =

+ net::URLFetcher::Create(webstore_data_url, net::URLFetcher::GET, this);

webstore_data_url_fetcher_->SetRequestContext(request_context_);

webstore_data_url_fetcher_->SetReferrer(referrer_url_.spec());

webstore_data_url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |