chrome/browser/local_discovery/gcd_api_flow_impl.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/gcd_api_flow_impl.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/intranet_redirect_detector.cc ('K') | « chrome/browser/intranet_redirect_detector.cc ('k') | chrome/browser/local_discovery/privet_url_fetcher.cc » ('j') | chrome/browser/media/webrtc_log_uploader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/gcd_api_flow_impl.cc

diff --git a/chrome/browser/local_discovery/gcd_api_flow_impl.cc b/chrome/browser/local_discovery/gcd_api_flow_impl.cc

index d4abd9329625f8e3803afba8d5ec475a324cb5dc..7e23c1b3aa6d5c807dca8b4b89ba21e08e48cf95 100644

--- a/chrome/browser/local_discovery/gcd_api_flow_impl.cc

+++ b/chrome/browser/local_discovery/gcd_api_flow_impl.cc

@@ -63,7 +63,7 @@ void GCDApiFlowImpl::OnGetTokenFailure(

void GCDApiFlowImpl::CreateRequest(const GURL& url) {

net::URLFetcher::RequestType request_type = request_->GetRequestType();

- url_fetcher_.reset(net::URLFetcher::Create(url, request_type, this));

+ url_fetcher_ = net::URLFetcher::Create(url, request_type, this);

if (request_type != net::URLFetcher::GET) {

std::string upload_type;