chrome/browser/extensions/blacklist_state_fetcher.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/blacklist_state_fetcher.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_ui_bindings.cc ('K') | « chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc ('k') | chrome/browser/extensions/blob_reader.cc » ('j') | chrome/browser/intranet_redirect_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/blacklist_state_fetcher.cc

diff --git a/chrome/browser/extensions/blacklist_state_fetcher.cc b/chrome/browser/extensions/blacklist_state_fetcher.cc

index 3af0bc5b7539d7c4071910f44d1c17e0471ef524..c74831eba56db7ba73184244db74c681157f0e3c 100644

--- a/chrome/browser/extensions/blacklist_state_fetcher.cc

+++ b/chrome/browser/extensions/blacklist_state_fetcher.cc

@@ -139,10 +139,9 @@ void BlacklistStateFetcher::SendRequest(const std::string& id) {

request.SerializeToString(&request_str);

GURL request_url = RequestUrl();

- net::URLFetcher* fetcher = net::URLFetcher::Create(url_fetcher_id_++,

- request_url,

- net::URLFetcher::POST,

- this);

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(url_fetcher_id_++, request_url,

+ net::URLFetcher::POST, this).release();

Ryan Sleevi 2015/04/30 18:23:44 ditto line 145

requests_[fetcher] = id;

fetcher->SetAutomaticallyRetryOn5xx(false); // Don't retry on error.

fetcher->SetRequestContext(url_request_context_getter_.get());