chrome/browser/devtools/devtools_ui_bindings.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc ('K') | « chrome/browser/chromeos/policy/upload_job.cc ('k') | chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc » ('j') | chrome/browser/extensions/blacklist_state_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index 9e134e3b0de17e0b2726523bc008f38e532510bf..2b739782533cd917c7b12bf76baf371b575a2ec5 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -590,7 +590,7 @@ void DevToolsUIBindings::LoadNetworkResource(const DispatchCallback& callback,

}

net::URLFetcher* fetcher =

- net::URLFetcher::Create(gurl, net::URLFetcher::GET, this);

+ net::URLFetcher::Create(gurl, net::URLFetcher::GET, this).release();

Ryan Sleevi 2015/04/30 18:23:44 maybe move this .release() to 594

pending_requests_[fetcher] = callback;

fetcher->SetRequestContext(profile_->GetRequestContext());

fetcher->SetExtraRequestHeaders(headers);