chrome/browser/chromeos/policy/upload_job.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/upload_job.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc ('K') | « chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | chrome/browser/devtools/devtools_ui_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/upload_job.cc

diff --git a/chrome/browser/chromeos/policy/upload_job.cc b/chrome/browser/chromeos/policy/upload_job.cc

index 6c0a621bcec77043b36a088f20a9f4258b99ecc0..3ef63ff7a5aa0527ead53a518a09608651638e08 100644

--- a/chrome/browser/chromeos/policy/upload_job.cc

+++ b/chrome/browser/chromeos/policy/upload_job.cc

@@ -314,8 +314,8 @@ void UploadJob::CreateAndStartURLFetcher(const std::string& access_token) {

std::string content_type = kUploadContentType;

content_type.append("; boundary=");

content_type.append(*mime_boundary_.get());

- upload_fetcher_.reset(

- net::URLFetcher::Create(upload_url_, net::URLFetcher::POST, this));

+ upload_fetcher_ =

+ net::URLFetcher::Create(upload_url_, net::URLFetcher::POST, this);

upload_fetcher_->SetRequestContext(url_context_getter_.get());

upload_fetcher_->SetUploadData(content_type, *post_data_);

upload_fetcher_->AddExtraRequestHeader(