Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
index 24396491e281791d2e0f79aaf6d03c4e39d88020..2aec7a65dc192955fd354fc4ec899c396365de6b 100644
--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
@@ -70,10 +70,11 @@ class FakeURLFetcherFactory : public net::FakeURLFetcherFactory {
   ~FakeURLFetcherFactory() override;
 
   // net::FakeURLFetcherFactory:
-  net::URLFetcher* CreateURLFetcher(int id,
-                                    const GURL& url,
-                                    net::URLFetcher::RequestType request_type,
-                                    net::URLFetcherDelegate* delegate) override;
+  scoped_ptr<net::URLFetcher> CreateURLFetcher(
+      int id,
+      const GURL& url,
+      net::URLFetcher::RequestType request_type,
+      net::URLFetcherDelegate* delegate) override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FakeURLFetcherFactory);
@@ -86,14 +87,15 @@ FakeURLFetcherFactory::FakeURLFetcherFactory()
 FakeURLFetcherFactory::~FakeURLFetcherFactory() {
 }
 
-net::URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
+scoped_ptr<net::URLFetcher> FakeURLFetcherFactory::CreateURLFetcher(
     int id,
     const GURL& url,
     net::URLFetcher::RequestType request_type,
     net::URLFetcherDelegate* delegate) {
-  net::URLFetcher* fetcher = net::FakeURLFetcherFactory::CreateURLFetcher(
-      id, url, request_type, delegate);
-  EXPECT_TRUE(fetcher);
+  scoped_ptr<net::URLFetcher> fetcher =
+      net::FakeURLFetcherFactory::CreateURLFetcher(id, url, request_type,
+                                                   delegate);
+  EXPECT_TRUE(fetcher.get());

[Ryan Sleevi, 2015/04/30 18:23:44]

EXPECT_TRUE(fetcher)

should be sufficient (with the bool converter helper)

   return fetcher;

[Ryan Sleevi, 2015/04/30 18:23:44]

This should be fetcher.Pass(), right?

 }